Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve transition display in outline #2010

Merged
merged 4 commits into from
Sep 28, 2023
Merged

Conversation

tf
Copy link
Member

@tf tf commented Sep 28, 2023

REDMINE-20217

tf added 4 commits September 28, 2023 07:04
We do not consolidate positions when removing sections to prevent
failing requests while deleting chapters. Collection length can, thus,
not be used to ensure unique position attributes.

REDMINE-20217
Chapter positions are needed to sort the global sections
collection. Ensure parent model is already set during initial sort,
such that previous sections can be determined correctly right from the
start.

Otherwise, the outline displays an incorrect transition after
inserting a section since the previous section can not yet be used to
determine available transitions.

REDMINE-20217
When inserting a section at the beginning of the entry, we need to
update the transition of the previously first section. Also the
section might no longer be the active section, even though
currentSectionIndex did not change.

REDMINE-20217
@tf tf added this to the v16.1.0 milestone Sep 28, 2023
@tf tf merged commit 9a7a985 into codevise:master Sep 28, 2023
16 checks passed
@tf tf deleted the improve-outline branch September 28, 2023 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant